-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRT Dynamic Reshape Fix #7412
Merged
Merged
TRT Dynamic Reshape Fix #7412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@trevor-m PTAL |
trevor-m
approved these changes
Feb 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@trevor-m Please re-review |
trevor-m
reviewed
Feb 8, 2021
trevor-m
approved these changes
Feb 10, 2021
comaniac
approved these changes
Feb 10, 2021
Thanks @codeislife99 @trevor-m |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
* Dynamic Reshape * Changes * Add test cases * Add test cases * PR COmments * CI Error * EmptyCommitCIError Co-authored-by: Ubuntu <[email protected]>
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* Dynamic Reshape * Changes * Add test cases * Add test cases * PR COmments * CI Error * EmptyCommitCIError Co-authored-by: Ubuntu <[email protected]>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* Dynamic Reshape * Changes * Add test cases * Add test cases * PR COmments * CI Error * EmptyCommitCIError Co-authored-by: Ubuntu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in TRT dynamic reshape offload and adds test cases for coverage of the bug.